Review of "Lyrics Indicator" version 7

Details Page Preview

Display synchronized lyrics in the top bar using lrclib.net. Features multi-player support, caching, manual editing, and rainbow mode.

Extension Homepage
https://github.com/antifantifa/-GNOME-Shell-Lyrics-Extension-lyrics-topbar.extension-

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

antifantifa posted a review
antifantifa posted a review
JustPerfection rejected
1. Soup version already selected in GNOME Shell code. So, line 5 `extension.js` won't change it. The best approach will be removing 42 from the supported shell versions and only use Soup 3: [Port Guide 43: Soup 3](https://gjs.guide/extensions/upgrading/gnome-shell-43.html#soup3) or, if you don't want to do that, create a helper function with version check and on 42 use the old API. 2. No need to use any parameters since you already specified that in `metadata.json`: - line 21 `extension.js` - line 7 `prefs.js` 3. Timeout should be removed on destroy (line 75 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 4. You should call `abort()` on disable or destroy (line 65 `extension.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 5. Unsubscribe on destroy (line 279 `extension.js`).