Review "Mantle" version 1 - GNOME Shell Extensions

Review of "Mantle" version 1

Details Page Preview

Mantle

by brrrenton

Manual tiling for Gnome

Extension Homepage: https://bitbucket.org/brrrenton/mantle/

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
1	Rejected

Previous Reviews on this Version

andyholmes rejected March 21, 2019

Most of your extension is acceptable, however you connect a number signals in `init()` which will never be disconnected, even if a user uninstalls your extension. These should instead be connected in `enable()` and disconnected in `disable()`. Please resubmit with these changes and I'll approve.