Review of "Dash2Dock Animated" version 1

Details Page Preview

The Animated & Effectful Dock

Extension Homepage
https://github.com/icedman/dash2dock-lite

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `package.json`: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. You cannot create objects in the constructor that `init()` returns: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization You should also null them out in disable. 3. Remove the timeout in disable (line 91 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 4. You should disconnect the signals in disable (line 34 and 35 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals 5. You are calling `_updateAppsButton()` in `disable()` but it's not guaranteed for `this.appButtonId` getting disconnected. 6. In line 23 (animator.js) use this instead: ```js var Animator = class { ``` and remove line 352. 7. Don't use single one condition for all of those signals in line 132-141 (animator.js). Each one of those disconnects should have one of it's own to avoid concurrency. 8. You are setting so many timeouts in line 164-168 (animator.js). Why? You shouldn't do that, and in any case the timeout should be removed in disable. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions