Review of "Dash2Dock Animated" version 29

Details Page Preview

The Animated & Effectful Dock

Extension Homepage
https://github.com/icedman/dash2dock-lite

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
What's the reason for monitoring session mode? You're disconnecting that in disable. Why do you need that?
icedman posted a review
To hide the docked dash on screen lock. A screen lock doesn't seem to disable the extension.
JustPerfection waiting for author
That's weird, where do you skip the disable? You don't have `session-modes` in `metadata.json`. Maybe that's related to not destroying and removing everything in disable properly. That shouldn't be fixed by monitoring the session mode.
icedman posted a review
I could no longer reproduce the bug in this gnome 44 version ... "bug: where the dock is not destroyed at screen lock". I'll disable the session mode monitoring. But I'll probably just limit this update to gnome 44.
JustPerfection rejected
Ok, please send the updated package.