Review of "Handy Scripts" version 2

Details Page Preview

Keep your bash scripts in the desktop for easy access.

Extension Homepage
https://github.com/lucaskenda/handyscripts

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

andyholmes rejected
On line #20 and #21 of `extension.js` you are assigning and using the variable `_indicator` instead of `button`. Although technically an error, usually this is just a warning but because you call `button.destroy()` in `disable()` instead of `_indicator.destroy()`, your extension does not cleanup properly, which means I have to reject it :( If you can fix that problem (and if possible add a URL to metadata.json) then there will be no problem approving your extension :)