Review "ColorTint" version 1 - GNOME Shell Extensions

Review of "ColorTint" version 1

Details Page Preview

ColorTint

by MatthewBarnard

Tint your desktop with a color of your choice to help with dyslexia, scopic sensitivity, and related conditions.

Extension Homepage: https://github.com/MattByName/color-tint

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
25	Active
24	Rejected
23	Inactive
22	Inactive
21	Inactive
20	Rejected
19	Active
18	Rejected
17	Inactive
16	Rejected
15	Rejected
14	Active
13	Inactive
12	Inactive
11	Inactive
10	Inactive
9	Inactive
8	Rejected
7	Inactive
6	Inactive
5	Rejected
4	Active
3	Rejected
2	Active
1	Rejected

Previous Reviews on this Version

andyholmes rejected April 27, 2019

Your extension looks mostly good, however it is not cleaning up after itself completely. Line #105: You should call both `Main.uiGroup.remove_actor(overlay);` and `overlay.destroy();`, to ensure the ClutterActor (StBin) is destroyed, before setting to `null`; Line #240: You should call `menu.destroy()` before `menu = null;`, to actually destroy the PanelButton. Setting to `null` isn't enough because the status area and it's corresponding ClutterActor each hold a reference to it. If you can fix these two, I'll be happy to approve :)

MatthewBarnard posted a review April 28, 2019

Hi Andy, Thanks for your really helpful feedback, and sorry for the rookie error. I'm uploading an updated version with the requested changes now. Best wishes, Matt