Review "Three Finger Window Move" version 1

Review of "Three Finger Window Move" version 1

Details Page Preview

Three Finger Window Move

by do-sch

Allows moving windows around with a three finger trackpad gesture (Wayland only)

Extension Homepage: https://github.com/do-sch/gnome-shell-touchpad-window-move

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Active

Previous Reviews on this Version

andyholmes active September 25, 2019

Looks pretty good. Two notes: You only need to call `Signals.addSignalMethods()` once since it applies functions to the class prototype, whereas `enable()` is going to be called every time the screen is unlocked, etc. Most folks put that function immediately under the class. You probably want to `gestureHandler = null` in `disable()` to drop the reference to the class instance. Otherwise that won't happen until it's overwritten the next time `enable()` is called. Nothing crucial :)

do-sch posted a review September 27, 2019

Thanks a lot for your feedback. I didn't know that `enable()` and `disable()` are called every time the screen is unlocked. The trifles are now eradicated. :)