Review "binaryclock DEPRECATED" version 1

Review of "binaryclock DEPRECATED" version 1

Details Page Preview

binaryclock DEPRECATED

by vancha

Adds a binary clock to the gnome bar Does not work for gnome shell 45 and up. Use the maintained version over at Adds a binary clock to the gnome bar

Extension Homepage: https://github.com/vancha/gnomeShellBinaryClock/

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
6	Active
5	Active
4	Active
3	Active
2	Active
1	Waiting for author

Previous Reviews on this Version

andyholmes waiting for author October 25, 2019

Your extension looks mostly good, however there are two problems: 1) You creating objects and connecting signals to them in `init()` which is strongly discouraged. This should be done in `enable()` and undone in `disable()`, or it may result in orphaned objects that the garbage collector can not free. 2) At the end of a ::repaint callback, you must call `context.$dispose()` or you will leak a small amount of memory each invocation If you can make these changes and submit a new version I will approve your extension.