Review of "Prime Indicator" version 4

Details Page Preview

Intel/NVIDIA GPU Switch

Extension Homepage
https://github.com/fffilo/prime-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Inactive
5 Active
4 Active
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

andyholmes posted a review
I can approve these submissions if you like, however you should be aware that if subclassing GObjects, you should always be using `GObject.registerClass()`, or you will likely encounter strange errors that are difficult to debug. GObject usage is described in the GJS wiki: https://gitlab.gnome.org/GNOME/gjs/blob/master/doc/Mapping.md
fffilo posted a review
@andyholmes I thought I did this. However I see i missed `var Icon = class Icon extends Gio.FileIcon { ... }` in `icon.js`. Is that what you are talking about? Or I missed it somewhere else also?
andyholmes active
Ah, you're right, I'm sorry. I forgot it was >= 3.34 when the menu items were ported to GObject. Yes, the GFileIcon class should be amended, although depending on how the constructor works in Gio, it may in fact work. I'll approve your extensions, and if you find it's a problem you can mark it "Inactive" yourself. I'm not sure if you're planning to continue releasing updated 3.32 versions, but you should submit a fix for the later versions as I believe GJS will start being more strict about `GObject.registerClass()` soon (the reason being the mysterious bugs and debugging I mentioned).
fffilo posted a review
Thank you very much!!!