GNOME Shell Extensions

Review of "Nbfc Indicator" version 3

Details Page Preview

Nbfc Indicator

by MGokcayK

Notebook Fan Control Indicator for Gnome Shell

Extension Homepage
https://github.com/MGokcayK/gnome-shell-extensions-nbfcindicator
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Active
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

andyholmes rejected
Although your extension is mostly okay, the reason your extension is being rejected is the dangling GSource in the event loop. Please be sure to remove the timeout GSource created at line #318 whenever your extension is disabled. The easiest place to do this is in the `destroy()` function of your PanelMenu.Button subclass.
MGokcayK posted a review
file:///home/mgokcayk/.local/share/gnome-shell/extensions/nbfcindicator@mgokcaykdev.gmail.com/extension.js
MGokcayK rejected