Review of "Overview or Applications" version 2

Details Page Preview

NOT MAINTAINED ANYMORE Show Applications grid with right click on Activities button. At the moment, it does not work along Desktop Icons extension.


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

fthx posted a review
Here is the new one. Sorry Andy for the previous upload, I knew that the signal wasn't disconnected but didn't know at this moment how to do it...! I hope this one is correct but I'm not sure.
andyholmes active
Yes, that should fix it. I will add some examples to the GNOME Wiki review page so this is easier to understand :)
fthx posted a review
Oh, you know it's just a matter of reading it. Ok I did not read all that BEFORE. :-p Thanks for your review work, again and again ! https://wiki.gnome.org/Projects/GnomeShell/Extensions/StepByStepTutorial Don’t do anything major in init() <----------------------------------------- I missed this one too, as you know... If you’re writing an extension, you must disconnect all signals and remove all Mainloop sources. Failure to do so will be an immediate rejection. So, if you connect to a signal using global.display.connect('window-created', onWindowCreated);, you need to disconnect it 1 let _windowCreatedId; 2 3 function enable() { 4 _windowCreatedId = global.display.connect('window-created', onWindowCreated); 5 } 6 7 function disable() { 8 global.display.disconnect(_windowCreatedId); 9 }