Review of "Journal" version 2

Details Page Preview

Zeitgeist based activity-history journal as a gnome-shell overview tab. It requires Zeitgeist to be installed.

Extension Homepage
http://git.gnome.org/gnome-shell-extensions

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Active
6 Active
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

gcampax posted a review
I don't know why you have your own copy of calendar.js and iconGrid.js. Removing those modules would make this easier to review. In any case, you're extension seems to work fine, but to be extra sure, you should explicitly disconnect all signals to external objects you don't control (like Main.overview::hiding), all dbus signals (in CalendarServer) and all GObject signals that could still be emitted (such as GSettings)
gcampax posted a review
Rejecting to get it off the queue.