I have migrated code to typescripts. Also I use webpack to generate js code.

ok, expect this to take a little while to review. Auto-generated code like this isn't super readable :)

Maybe reviewing from source code can be easier. Source code is here: https://github.com/oae/gnome-shell-extensions-sync Also if you want to make sure my code and this generated code are the same(for security reasons) you can build the source code can compare them. :). Also, I can minify the code thanks to Webpack. Do you think it can improve the performance of the extension?

> Maybe reviewing from source code can be easier. Source code is here: https://github.com/oae/gnome-shell-extensions-sync > Also if you want to make sure my code and this generated code are the same(for security reasons) you can build the source code can compare them. Sorry, I don't really have the time to fetch and new learn tooling to review extension submissions. It would be best to use something like rollup (https://rollupjs.org/guide/en/), that produces readable native ES6 javascript. > Also, I can minify the code thanks to Webpack. Do you think it can improve the performance of the extension? No, the purpose of minifying is to reduce network usage to speedup webpage loading, which doesn't really apply here. minifying won't have any meaningful affect on the parsing or execution speed and I definitely won't review minified code myself. To be honest, I would look into leveraging the GNOME platform APIs and the overhead webpack is adding to you extension. By wrapping a number of essentially synchronous operations in Promises you're really just deferring them to run synchronously later, and adding extra events to the main loop. Additionally it seems you might be leaking file descriptors in your usage of `GLib.spawn_async_with_pipes`. I would recommend you look into the tools available in Gio like `Gio.SubprocessLauncher`.

newer version approved