Review of "VPN and SNX Indicator" version 3

Details Page Preview

A status indicator for a VPN and SNX(Check Point) connection.

Extension Homepage
https://github.com/alexeylovchikov/vpn-indicator-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Rejected
9 Rejected
8 Active
7 Rejected
6 Rejected
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

alexey.lovchikov posted a review
alexey.lovchikov posted a review
Added check SNX activity Added console menu to dissconnect SNX VPN
andyholmes waiting for author
There are some problems with your extension you will have to fix before it can be approved. 1) You are adding a mainloop source that is never removed when your extension is disabled. You should destroy this when your extension is disabled. 2) You are passing `GLib.SpawnFlags.DO_NOT_REAP_CHILD` to `GLib.spawn_async()` with out adding a child watch or ever closing the PID. You either not pass this flag, or add a child watch callback that calls `GLib.spawn_close_pid()`.
alexey.lovchikov posted a review
I did not understand a little about GLib.SpawnFlags.DO_NOT_REAP_CHILD, I removed this parameter. I rewrote a significant portion of the code
alexey.lovchikov rejected