Review "Auto Day/Night Theme Switch [DEPRECATED]" version 1

Review of "Auto Day/Night Theme Switch [DEPRECATED]" version 1

Details Page Preview

Auto Day/Night Theme Switch [DEPRECATED]

Automatically switch themes depending on the time of the day NOTE: Deprecated for GNOME > 3.36, please use Night Theme Switcher instead

Extension Homepage: https://github.com/Darazaki/AutoDayNightThemeSwitch

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
2	Active
1	Active

Previous Reviews on this Version

andyholmes active May 13, 2020

It would be much better to disconnect any signals you connect, rather than hoping the garbage collector can break any reference cycles it encounters.

Darazaki posted a review May 13, 2020

Understood and thank you for your review! After using `disconnect`, is it okay to keep doing `settings = null` or should I leave those references alive?

andyholmes posted a review May 14, 2020

Yes, setting global variables to `null` is a good idea, since the garbage collector will know to immediately collect them. Otherwise that won't happen until they are overwritten in `setupExtensionSettings()`, etc.

Darazaki posted a review May 14, 2020

Ok makes sense, it should be an easy fix then. Thank you very much!