Review of "Night Light Slider" version 15

Details Page Preview

A GNOME extension to manage the built-in night light temperature

Extension Homepage

No comments.

Diff Against


Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
23 Active
22 Active
21 Active
20 Inactive
19 Active
18 Active
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Rejected
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Inactive
2 Active
1 Rejected

Previous Reviews on this Version

andyholmes active
That is the correct way to disconnect signals. Typically (in C) signals are automatically disconnected when the reference count drops to 0. In GJS, any variable pointing to an Object will prevent that. In the case of your extension, so long as your callbacks are only triggered from inside the Extension object and only access variables that are guaranteed to exist, you don't need to manually disconnect those signals.