Review "Lidsleep" version 1 - GNOME Shell Extensions

Review of "Lidsleep" version 1

Details Page Preview

Lidsleep

by pablotor

Disable the auto suspend when lid is closed

Extension Homepage: https://github.com/pablotor/gnome-shell-extension-lidsleep

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
2	Active
1	Active

Previous Reviews on this Version

andyholmes active August 2, 2020

Looks good. Some tips: * The methods from convenience.js are now a part of gnome-shell in `extensionUtils.js` * `Lang.Class` is unnecessary and you can you use `GObject.registerClass()` for subclassing * https://wiki.gnome.org/Projects/GnomeShell/Extensions/MigratingShellClasses * `Lang.bind()` can be replaced with `Function.prototype.bind()` or arrow functions `() => {}` instead * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_objects/Function/bind * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions

pablotor posted a review August 3, 2020

Thanks for the review and tips. I updated extension.js with your suggestions and pushed the new version to github. How do I submit the new version here?

andyholmes posted a review August 3, 2020

Just increment the version in `metadata.json` before you pack up the ZIP and upload at the same place (https://extensions.gnome.org/upload/). The website will know its the same extension by the UUID field :)