Review "User style sheet" version 1 - GNOME Shell Extensions

Review of "User style sheet" version 1

Details Page Preview

User style sheet

by TomaszGasior

Load custom style sheet from ~/.config/gnome-shell/gnome-shell.css.

Extension Homepage: https://github.com/TomaszGasior/gnome-shell-user-stylesheet

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

andyholmes rejected August 8, 2020

Your extension is not cleaning up after itself properly. On line #31 of extension.js you are not storing the handler ID for the signal, and one line #43 you are passing the function instead of that ID Instead you should store the Id in the top-level scope and disconnect using that: ``` // somewhere around line #10 let desktopSettingsId = 0; // line #31 desktopSettingsId = desktopSettings.connect('changed', desktopSettingsChangedFunc); // line #43 if (desktopSettingsId !== 0) { desktopSettings.disconnect(desktopSettingsId); desktopSettingsId = 0; } ``` Please fix this so I can approve your extension.