Review of "User style sheet" version 1

Details Page Preview

Load custom style sheet from ~/.config/gnome-shell/gnome-shell.css.

Extension Homepage
https://github.com/TomaszGasior/gnome-shell-user-stylesheet

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

andyholmes rejected
Your extension is not cleaning up after itself properly. On line #31 of extension.js you are not storing the handler ID for the signal, and one line #43 you are passing the function instead of that ID Instead you should store the Id in the top-level scope and disconnect using that: ``` // somewhere around line #10 let desktopSettingsId = 0; // line #31 desktopSettingsId = desktopSettings.connect('changed', desktopSettingsChangedFunc); // line #43 if (desktopSettingsId !== 0) { desktopSettings.disconnect(desktopSettingsId); desktopSettingsId = 0; } ``` Please fix this so I can approve your extension.