Review of "Minimize to Tray" version 5

Details Page Preview

Minimize any app to tray (Xorg only) Make sure you have xdotool, xwininfo, xprop, libwnck3 installed on your system.

Extension Homepage
https://github.com/oae/gnome-shell-minimize-to-tray

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

andyholmes active
Please don't use webpack for extensions, it generates code that is extremely difficult to review. Consider using a cleaner tool like rollup instead. There is a bug in your preferences dialog that prevents new additions, you should fix that for your next release.
andyholmes rejected
Please don't use webpack for extensions, it generates code that is extremely difficult to review. Consider using a cleaner tool like rollup instead. There is a bug in your preferences dialog that prevents new additions, you should fix that for your next release.
andyholmes posted a review
Sorry about the comment noise, there is also a failure in your extension that causes GNOME Shell to crash: ``` == Stack trace for context 0x555abb5736b0 == #0 555abd7f06c8 i /home/andrew/.local/share/gnome-shell/extensions/minimize-to-tray@elhan.io/extension.js:358 (14bf015e9e20 @ 334) #1 555abd7f0630 i self-hosted:1291 (14bf015506a0 @ 28) #2 7ffe95e001a0 b self-hosted:1246 (24c559eec268 @ 208) #3 555abd7f0588 i /home/andrew/.local/share/gnome-shell/extensions/minimize-to-tray@elhan.io/extension.js:295 (14bf01574790 @ 22) ```
alperenelhan posted a review
I will try to migrate it to rollup. There are some dependencies like xdotool, xwininfo, xprop, libwnck3 for new addition to work.