Review of "Jenkins CI Server Indicator" version 9

Details Page Preview

Provides an overview of all jobs on your Jenkins CI Server.

Extension Homepage
http://www.philipphoffmann.de/gnome-3-shell-extension-jenkins-ci-server-indicator/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Rejected
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Waiting for author
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

gcampax rejected
You should use Soup.Session::authenticate: instead of building the Authorization header yourself.
p.hoffmann posted a review
Yeah, i know about Soup.Session::authenticate. The thing is that Jenkins only supports preemptive authentication which basically means that you get rejected right away (403 - forbidden) on the first request if you dont provide any authentication information. Using the authentication method of Soup would mean that Soup tries to request the URL, returns a SoupAuth object (which if have to provide with the username/password), then tries to request the URL again with the authentication information. I tried to do it this "soup-way" first but, like I already said, I get rejected right away on the first request. So I dont even get a SoupAuth object which I can then use to provide username and password. Thats why I chose to inject the authentication header myself. You want me to put in some more comments to clarify this circumstance? I'd also be delighted if you know another solution to this :-)
p.hoffmann waiting for author
hey, its been one week :-( is somebody still reviewing this?