Review "Notification Timeout" version 1

Review of "Notification Timeout" version 1

Details Page Preview

Notification Timeout

by chlumskyvaclav

This extension allows configuring the same timeout for all notifications. It also allows ignoring the idle state.

Extension Homepage: https://github.com/vchlum/notification-timeout

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
12	Active
11	Active
10	Active
9	Rejected
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

ewlsh rejected November 11, 2020

Take a look at https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review You can't create objects or connect signals in init(), those belong in enable(). You also should store the output signal ID and disconnect in disable() Additionally, you should store your copies of the original functions in init() or in the global scope, enable() can be called after they've already been modified.