Review "toggle xpad" version 1 - GNOME Shell Extensions

Review of "toggle xpad" version 1

Details Page Preview

toggle xpad

by phamthainb

An button on top bar for toggle Xpad note

Extension Homepage: https://github.com/phamthainb/toogle-xpad.git

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
3	Active
2	Rejected
1	Rejected

Previous Reviews on this Version

ewlsh rejected November 14, 2020

Welcome! In disable() you need to... toogleXpad.destroy() toggleXpad = null ...otherwise your extension will keep a reference to the old version even while disabled. You shouldn't need to call remove_child once destroyed. Prefer Main.panel.addToStatusArea (https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/master/js/ui/panel.js#L1110) over directly inserting into a box. Main.panel.addToStatusArea('xpad-toggle', toogleXpad, /* a positioning number */ 5); See https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review