Review of "Simple monitor" version 2

Details Page Preview

A simple panel button that shows CPU and RAM memory usage. Clicking shows the top 10 processes using CPU and memory.

Extension Homepage
https://github.com/fcaballerop/simple-monitor-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

reytisker posted a review
As per review of v1, I changed all process callings to asynchronous calls, cleaned a bit in general, and also called super._onDestroy at the end
andyholmes rejected
Newer version approved. If passing the `G_SPAWN_DO_NOT_REAP_CHILD` you must use a child watch function or you will leave zombie processes. Additionally spawning an process asynchronously then reading the output synchronously will still block the main thread. Perhaps you want to consider using `Gio.Subprocess.communicate_utf8_async()` for this use case. There are some examples here: https://www.andyholmes.ca/articles/subprocesses-in-gjs.html#communicating-with-processes