Review "One Drive" version 1 - GNOME Shell Extensions

Review of "One Drive" version 1

Details Page Preview

One Drive

by diegobazzanella

One Drive extension

Extension Homepage: https://github.com/dbazza/oneDrive

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
4	Active
3	Rejected
2	Active
1	Rejected

Previous Reviews on this Version

andyholmes rejected December 16, 2020

You add a mainloop source which is never removed on line #101. All mainloop sources must be removed when `disable()` is called. Please fix this so your extension can be approved. See the review tips here: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review You can also use `Gio.AppInfo.launch_default_for_uri()` instead of spawning `xdg-open`, and `GLib.find_program_in_path()` instead of spawning `which`. * https://gjs-docs.gnome.org/gio20/gio.appinfo#function-launch_default_for_uri * https://gjs-docs.gnome.org/glib20/glib.find_program_in_path If you don't need the output from a command, you should use `GLib.spawn_command_line_async()`. * https://gjs-docs.gnome.org/glib20/glib.spawn_command_line_async