Review of "Brightness Button" version 2

Details Page Preview

Toggle dim brightness on and off by clicking an icon on the panel.

Extension Homepage
https://github.com/PierrickF/brightness-button

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Active
1 Waiting for author

Previous Reviews on this Version

JustPerfection active
Approved but please fix these for the next version: 1. You could do this on disable(): Main.panel._rightBox.remove_child(button); button.destroy(); 2. Remove this line which is unused import: const Tweener = imports.ui.tweener; 3. Remove x_fill and y_fill from button but add this to the Icon: y_align: Clutter.ActorAlign.CENTER to have that you need to import Clutter: const Clutter = imports.gi.Clutter; Your extension can also support GNOME Shell 40 if you do these. If you need any help with your extension you can ask us on GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org