Review of "Simply Workspaces" version 3

Details Page Preview

Workspace indication with an i3/polybar style.

Extension Homepage
https://github.com/andyrichardson/simply-workspaces

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Still has error: JS ERROR: Extension simply.workspaces@andyrichardson.dev: Error: Dynamic workspaces are not supported. @/home/ice/.local/share/gnome-shell/extensions/simply.workspaces@andyrichardson.dev/extension.js:13:9 _callExtensionInit@resource:///org/gnome/shell/ui/extensionSystem.js:422:13 _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:145:18 _onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:493:35 _onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:493:14 createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:516:46 enableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:194:29 EnableExtension@resource:///org/gnome/shell/ui/shellDBus.js:310:38 _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:310:38 _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:387:34 If you think it can make it easier to pass, you can check how many workspaces are there. If there isn't 10 of them, just don't allow the extension to get enabled and show proper text instead of numbers in top panel. For example, "Only works when you set 10 static workspaces".
andyrichardson posted a review
Hey there, that error is intentional - https://github.com/andyrichardson/simply-workspaces/blob/master/extension.js#L9 I've added instructions to the README - https://github.com/andyrichardson/simply-workspaces
JustPerfection posted a review
Hi, I explained about this one in the next version.