Review "Docker Integration" version 1 - GNOME Shell Extensions

Review of "Docker Integration" version 1

Details Page Preview

Docker Integration

by xxx01x

A status menu for managing docker containers.

Extension Homepage: https://github.com/gpouilloux/gnome-shell-extension-docker

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
1	Active

Previous Reviews on this Version

JustPerfection active July 3, 2021

Approved but please fix these for the next release: 1. Remove Lang from src/dockerSubMenuMenuItem.js: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice 2. Fix this warning: Usage of object.actor is deprecated for DockerMenu get@resource:///org/gnome/shell/ui/environment.js:317:29 _init@/home/ice/.local/share/gnome-shell/extensions/docker_status2@gpouilloux/src/dockerMenu.js:45:9 enable@/home/ice/.local/share/gnome-shell/extensions/docker_status2@gpouilloux/extension.js:35:18 _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32 _onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:493:35 _onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:493:14 createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:516:46 enableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:194:29 EnableExtension@resource:///org/gnome/shell/ui/shellDBus.js:310:38 _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:310:38 _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:387:34 3. Remove these files: - .editorconfig - .gitignore - build.sh https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Don.27t_include_unecessary_files

JustPerfection posted a review July 3, 2021

btw, replace "40.0" with "40". In that case it will support all minor versions of 40. Please come to GNOME Matrix channel if you have any questions about extensions: https://matrix.to/#/#extensions:gnome.org