Review "TuneD Profile Switcher" version 1

Review of "TuneD Profile Switcher" version 1

Details Page Preview

TuneD Profile Switcher

Displays a list of the TuneD profiles and allows to switch between them. Of course, this is works only when TuneD installed and running.

Extension Homepage: https://github.com/vint21h/gnome-shell-extension-tuned-profile-switcher/

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected July 10, 2021

Please fix these issues to get approved: TESTED on Fedora 35 GNOME 40.2 Some code accessed the property 'TunedProxyAdapter' on the module 'dbus'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway. JS ERROR: [TuneD Profile Switcher]: error. Gio.DBusError: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable: Gio.DBusError: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable _proxyInvoker@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:122:46 _makeProxyMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:147:30 get activeProfile@/home/ice/.local/share/gnome-shell/extensions/tuned-profile-switcher@vint21h.pp.ua/dbus.js:53:37 _init@/home/ice/.local/share/gnome-shell/extensions/tuned-profile-switcher@vint21h.pp.ua/widget.js:40:41 enable@/home/ice/.local/share/gnome-shell/extensions/tuned-profile-switcher@vint21h.pp.ua/extension.js:32:24 _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32 _onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:493:35 _onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:493:14 createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:516:46 enableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:194:29 EnableExtension@resource:///org/gnome/shell/ui/shellDBus.js:310:38 _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:310:38 _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:387:34

JustPerfection posted a review July 10, 2021

You can always ask questions related to the extensions by joining us on GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org

vint21h posted a review July 11, 2021

Hi, - JS ERROR: [TuneD Profile Switcher]: error. Gio.DBusError: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable: Gio.DBusError: maybe the extension description is not fully clear, this extension communicates with TuneD service through DBus, and where it's not available, the extension does not show any widgets or anything because we can't communicate with TuneD because it's pointless. So, if I write more clear description about this extension use cases it will be more acceptable? - Some code accessed the property 'TunedProxyAdapter' on the module 'dbus'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.: if I replace this: class TunedProxyAdapter {} by this: class TunedProxyAdapterClass {} var TunedProxyAdapter; it will be more acceptable?

JustPerfection posted a review July 11, 2021

Instead of this: `class TunedProxyAdapter {` write this: `var TunedProxyAdapter = class {` For error: yes. you can add description.