Review of "Pidgin IM integration" version 38

Details Page Preview

Integrate Pidgin IMs in the Gnome Shell message tray

Extension Homepage
https://github.com/muffinmad/pidgin-im-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
Thanks for porting your extensions to GNOME Shell 40. 1. Rejected because: You cannot create objects in init: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization move `this._settings = Convenience.getSettings();` and `this._proxy = new Pidgin(Gio.DBus.session, 'im.pidgin.purple.PurpleService', '/im/pidgin/purple/PurpleObject');` to enable(). 2. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice You can use GObject instead: https://gjs.guide/guides/gjs/legacy-class-syntax.html#comparison-between-legacy-and-es6-implementations Learn More about removing Lang: https://wiki.gnome.org/Projects/GnomeShell/Extensions/MigratingShellClasses You can always ask questions related to the extensions by joining us on GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org