Review "Hide panel (only when active window is fullscreen)" version 1

Review of "Hide panel (only when active window is fullscreen)" version 1

Details Page Preview

Hide panel (only when active window is fullscreen)

by freder

hide top panel only when a fullscreen application has focus

Extension Homepage: https://github.com/freder/hide-panel-for-fullscreen-windows-only

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected August 30, 2021

Rejected because: 1. You cannot bind in constructor. move that to enable(): https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization 2. On Disable you should remove the signal you have connected. And for that TODO: Because you are using PanelBox instead of Main.panel ;) and adding styles like that is wrong because you have to remove it on disable. It's better to use "add_style_class_name" and "remove_style_class_name" and use a css class in stylesheet.css. Please join us on GNOME Matrix channel if you need any help with that: https://matrix.to/#/#extensions:gnome.org

freder posted a review August 30, 2021

thanks for your input