Review of "Auto Night Light" version 1

Details Page Preview

Automatically adjust night light

Extension Homepage
https://github.com/Zefty/AutoNightLight

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active
1. Rejected because you cannot create objects and connect signals in init function (extension.js). Move everything from constructor() to enable(): https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization 2. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice You can use GObject instead: https://gjs.guide/guides/gjs/legacy-class-syntax.html#comparison-between-legacy-and-es6-implementations Learn more about removing Lang: https://wiki.gnome.org/Projects/GnomeShell/Extensions/MigratingShellClasses 3. You need to fix these errors (you can see these errors in `journalctl -f`): JS ERROR: TypeError: this._scheduleDataModel.get_path(...) is null _bindEventHandlers/<@/home/ice/.local/share/gnome-shell/extensions/autonightlight@zefty.github.io/prefs.js:148:57 run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20 main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13 run@resource:///org/gnome/gjs/modules/script/package.js:206:19 start@resource:///org/gnome/gjs/modules/script/package.js:190:8 @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17 JS ERROR: Error: Don't know how to convert GType (null) to JavaScript object _bindEventHandlers/<@/home/ice/.local/share/gnome-shell/extensions/autonightlight@zefty.github.io/prefs.js:160:58 run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20 main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13 run@resource:///org/gnome/gjs/modules/script/package.js:206:19 start@resource:///org/gnome/gjs/modules/script/package.js:190:8 @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17 If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection rejected