Review of "Orange Share" version 5

Details Page Preview

A small python server that accepts requests from an apple shortcut to allow sharing all sorts of media from iOS. It allows sending content right from the share sheet - similar to AirDrop between Apple Devices

Extension Homepage
https://github.com/Yannis4444/Orange-Share/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Rejected
4 Waiting for author
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Thanks for moving the Python scripts to pip. "Please fix #1 and #2 and your extension will be approved." 1. Rejected because `orangeShare.disconnect("button-press-event");` is wrong and leads to fatal error on disable. `disconnect` accepts the signal id, not string of signal name. Means you should do this instead: this.buttonPressSignalID = this.connect('button-press-event', Lang.bind(this, function (display, action, deviceId, timestamp) { ... and for disconnect: orangeShare.disconnect(orangeShare.buttonPressSignalID); Since the signal is connected to the object and you destroy that object on disable(), you don't need to disconnect the signal, just these would be enough: function disable() { orangeShare.disable() orangeShare.destroy(); orangeShare = null; } 2. Please also use `orangeShare = null;` on disable(). 3. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice You can use GObject instead: https://gjs.guide/guides/gjs/legacy-class-syntax.html#comparison-between-legacy-and-es6-implementations Learn more about removing Lang: https://wiki.gnome.org/Projects/GnomeShell/Extensions/MigratingShellClasses 4. Your extension should also work on GNOME Shell 41. You can test that on Fedora 35 or GNOME OS Nightly. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions