Review of "UTCClock" version 25

Details Page Preview

UTC clock for the top bar

Extension Homepage
https://github.com/injcristianrojas/UTCClock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Inactive
25 Inactive
24 Active
23 Active
22 Rejected
21 Rejected
20 Active
19 Active
18 Rejected
17 Active
16 Rejected
15 Rejected
14 Active
13 Inactive
12 Active
11 Rejected
10 Active
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

injcristianrojas auto- active
JustPerfection posted a review
1. "40.0" and "41.0" only support those versions. Use "40", "41" if you want to support all of those minor versions (40.0, 40.1, 40.2,..., 41.0, 41.1, 41.2, ...). 2. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice Learn more about removing Lang: https://wiki.gnome.org/Projects/GnomeShell/Extensions/MigratingShellClasses I recommend to remove 3.32 and 3.34 from "shell-version" and then remove the Lang. It's better to remove all "shell-version"s lower than 40 though. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
injcristianrojas posted a review
Isn't there anything better? My uses of Lang are just for signal creation and I don't want to install an IRC/Matrix program just for this.
JustPerfection posted a review
np ;) Removing Lang is very easy. Some examples from your code: ## Old Code 1 this.menuSignal2 = this.PopupMenuItemUTC.connect('activate', Lang.bind(this, function() { this.settings.set_string("time-text", "UTC"); })); ## New Code 1 this.menuSignal2 = this.PopupMenuItemUTC.connect('activate', () => { this.settings.set_string("time-text", "UTC"); }); ## Old Code 2 this.settingsSignals[0] = this.settings.connect( "changed::show-seconds", Lang.bind(this, this.setSecondsDisplayed) ); ## New Code 2 this.settingsSignals[0] = this.settings.connect( "changed::show-seconds", this.setSecondsDisplayed.bind(this) );
injcristianrojas posted a review
Thank you very much. I'll push a new version in minutes.