Review "TailDrop Send" version 1 - GNOME Shell Extensions

Review of "TailDrop Send" version 1

Details Page Preview

TailDrop Send

by drecol

Send files via tailscale

Extension Homepage: https://github.com/fr233/gnome-shell-extension-taildropsend

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected October 3, 2021

1. You cannot create objects in global scope (extension.js line 201): https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization 2. Description doesn't say anything about extension. 3. Use getSettings() from ExtensionUtils instead of creating your own custom function: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions

drecol posted a review October 4, 2021

@JustPerfection Thanks, I've fix those issues