Review of "gTile" version 46

Details Page Preview

Tile windows on a grid

Extension Homepage
https://github.com/gTile

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you cannot create objects in global scope: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization Mean you should move this line to enable(): const mySettings = Settings.get(); 2. You are doing too much `let settings = Settings.get();` in prefs.js. do that once in buildPrefsWidget() and then pass it to the functions needed that. 3. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. You can use ExtensionUtils.getSettings() instead of creating your own custom function (3.36 and higher): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
scherepanov posted a review
Thanks for pointing out what can be improved in gTile. Your advises are appreciated. I implemented 1) and 2), and partially done 3). Will fully remove Lang in next version. I am trying to keep gTile compatible back to gnome-shell v 3.32, so I will not do 4) at this time. Please check next version of gTile that I am uploading to EGO.
JustPerfection posted a review
Multi versioning is also supported here. You can use that if you like. Anyway, take your time. technically you can still use Lang on 41.