Review "Dell Command Configure menu" version 1

Review of "Dell Command Configure menu" version 1

Details Page Preview

Dell Command Configure menu

Adds submenu in gnome shell to access Dell Command Configure options. Currently, only battery charge settings are implemented. The Dell Command Configure tool must be installed separately from Dell https://www.dell.com/support/kbdoc/en-uk/000178000/dell-command-configure#Downloads.

Extension Homepage: https://github.com/vsimkus/gnome-shell-extension-dell-command-configure-menu

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
8	Active
7	Active
6	Active
5	Rejected
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected October 13, 2021

1. You cannot create objects in `DellCommandControlMenuExtension.constructor()`: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization Move this line to enable(): this.settings = ExtensionUtils.getSettings(Me.metadata['settings-schema']); 2. Remove `stylesheet.css` since you are not using it: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Don.27t_include_unecessary_files 3. Merge line 33 with 21 (extension.js). If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions

vsimkus posted a review October 13, 2021

Thanks for the quick response. The GJS tutorial creates the Settings object in the constructor of the extension: https://gjs.guide/extensions/development/preferences.html#integrating-gsettings. That's why I also included it in the constructor. But I am happy to move it to enable on resubmission.

JustPerfection posted a review October 13, 2021

Thanks for reporting. We will fix that.