Review of "Poweroff Button on Topbar" version 2

Details Page Preview

Add poweroff button on topbar

Extension Homepage
https://github.com/Darknico/GNOME-Shell-Extensions

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Inactive
3 Active
2 Rejected
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
You cannot create objects in Extension.constructor() : https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization Move everything from constructor to enable. Also you should do these on disable: icon.destroy(); button.destroy(); icon = null; button = null; Also remove unused `text` variable. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Darknico posted a review
Thanks for review. I updated with fix