Review of "Walkpaper" version 8

Details Page Preview

Set different wallpaper for each workspace by having the wallpaper switch on workspace change.

Extension Homepage
https://github.com/BlinkBP/walkpaper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Rejected
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init function (extension.js line 14): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization to fix that: ```js let _settings; function enable() { _settings = ExtensionUtils.getSettings(); // ... } function disable() { this._settings?.run_dispose(); this._settings = null; // ... } ``` 2. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions