Review "Netctl Menu" version 1 - GNOME Shell Extensions

Review of "Netctl Menu" version 1

Details Page Preview

Netctl Menu

by tjaart

Netctl Menu allows you to switch between netctl profiles using a menu in the notification area.

Extension Homepage: https://github.com/tjaartvdwalt/netctl-gnome-shell-extension

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
2	Active
1	Rejected

Previous Reviews on this Version

gcampax rejected April 16, 2013

spawn_async_with_pipes will provide you with open FDs for stdin, stdout and stderr, which you must close (by first wrapping them in a Gio.UnixInputStream/Gio.UnixOutputStream). Or just use spawn_async(), if you don't need the streams. Also, if you pass DO_NOT_REAP_CHILD, you are responsible of keeping the PID and creating a GLib.ChildWatch, or it becomes a zombie.