Review of "History Manager Prefix Search" version 15

Details Page Preview

Use PageUp and PageDown to move in HistoryManager (eg. Run Command, Looking Glass) according to prefix

Extension Homepage
https://github.com/sustmi/gnome-shell-extension-historymanager-prefix-search

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
22 Active
21 Active
20 Active
19 Rejected
18 Active
17 Active
16 Rejected
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

sustmi auto- active
JustPerfection rejected
# Rejection Reasons 1. You cannot create objects in init function. Move line 133 (extension.js) to enable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Do this on disable: ```js settings = null; ``` 3. Remove line 24 (extension.js). You shouldn't import prefs file into the GNOME Shell. Instead, Add this to metadata.json: ```json "settings-schema": "org.gnome.shell.extensions.historymanager-prefix-search", ``` Now `ExtensionUtils.getSettings()` or `Convenience.getSettings()` can get the value without schema id parameter. # Recommendation Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (supported on 3.34 and higher): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js remove convenience.js after that. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions