Review of "Notes" version 21

Details Page Preview

Sticky notes for the GNOME Shell desktop.

Extension Homepage
https://github.com/maoschanz/notes-extension-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
23 Active
22 Active
21 Rejected
20 Active
19 Active
18 Active
17 Active
16 Inactive
15 Active
14 Active
13 Rejected
12 Inactive
11 Rejected
10 Inactive
9 Inactive
8 Rejected
7 Inactive
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove all .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 3. Remove line 223 (extension.js) and return this instead: return GLib.SOURCE_REMOVE; 4. Timeout id in line 217 (extension.js) should be removed on disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources You can do that in NotesManager.destroy(). 5. Also do these on disable(): ```js if (NOTES_MANAGER) { NOTES_MANAGER = null; } if (SETTINGS) { SETTINGS = null; } ``` If you want to port your extension to 40 and 41: https://gjs.guide/extensions/upgrading/gnome-shell-40.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions