Review "CryptoWatch" version 1 - GNOME Shell Extensions

Review of "CryptoWatch" version 1

Details Page Preview

CryptoWatch

by d0x2f

Display live crypto portfolio balances.

Extension Homepage: https://github.com/d0x2f/CryptoWatch

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
10	Active
9	Inactive
8	Inactive
7	Inactive
6	Inactive
5	Inactive
4	Inactive
3	Inactive
2	Rejected
1	Inactive

Previous Reviews on this Version

JustPerfection rejected November 27, 2021

coincap.js line 112 should be called from enable. Everything in global scope will be called just like init: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions

JustPerfection posted a review November 27, 2021

JustPerfection active November 27, 2021

Approved. Seems addSignalMethods is just adding the signals to the proto: https://gitlab.gnome.org/GNOME/gjs/-/blob/4fa8279ebff4ab462f26370b68599d6f401df8d2/modules/core/_signals.js#L129-143