Review of "Animation Tweaks" version 15

Details Page Preview

Add animations to different items and customize them. Please reset the extension after updating. The Extension will stop when upgraded to an incompatible version. In that case an Update tab is created to easily reset the extension. A Reset menu entry is also always present in in the Top Right Application menu of the extension preferences window. A Default shortcut combination of Super Key + t is provided to disable the extension. Some effects might not work properly on wayland, for which an option to integrate with wayland is provided on Integrations tab. However, some animations might not work properly. To manage effect Delay time enable Show delay time in preferences Window from Top Right Application menu -> Preferences and reopen preferences.

Extension Homepage
https://github.com/Selenium-H/Animation-Tweaks

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
18 Active
17 Rejected
16 Rejected
15 Rejected
14 Active
13 Inactive
12 Active
11 Active
10 Inactive
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. The timeout id in line 56 (extension.js) should be removed in disable without those checks. The fact you are replacing it with some chars (like "k", "s" and "n") means you are mixing the logic behind the timeout id with something else. 2. You forgot to remove the timeout in line 621 (extension.js) on disable. 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. Remove .po and locale/readme.md files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
Also remove .pot file.
Selenium-H posted a review
Ok, I'll try implementing the chnages
JustPerfection posted a review
Thanks.