Review of "Pause Night Light" version 9

Details Page Preview

Disable Night Light for 10 seconds. This short interruption allows you to scan a colour code (e.g. Crontosign) from your screen.

Extension Homepage
https://github.com/tijn/pause-night-light

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Rejected
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

tijn auto- active
JustPerfection rejected
1. Rejected because you cannot create objects in init function (line 45 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization to fix that, you need to move that line to enable. 2. Please remove all .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 3. Use ExtensionUtils.initTranslations() instead of creating your own custom function (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Use "40" and "41" instead of "40.0" and "41.0". "40" means all minor versions of 40 are supported. 5. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions