Review of "Rounded System Menu Buttons" version 5

Details Page Preview

Rounded System Menu Buttons

Extension Homepage
https://github.com/PRATAP-KUMAR/rounded-system-menu-buttons

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
You should remove `_syncLabel._resetHoverTimeoutId` in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
PRATAP PANABAKA posted a review
Do you mean like this? ...................... /////////////// edited as per comments but unsure - START \\\\\\\\\\\\\\\\\\\\ if(this._resetHoverTimeoutId ) { GLib.Source.remove(this._resetHoverTimeoutId) }; /////////////// edited as per comments but unsure - END \\\\\\\\\\\\\\\\\\\\\\\ modifiedMenu = null; }
JustPerfection posted a review
`this` doesn't refer to _syncLabel in disable(). You can create `_syncLabel._onDestroy()` and remove the timeout there. For example: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/65450a836ee9e0722a2d4c3327f52345eae293c6/js/ui/altTab.js#L283
PRATAP PANABAKA posted a review
Thank you for your guidance, from line 146, the edited content from extension.js file is GLib.Source.set_name_by_id(this._resetHoverTimeoutId, '[gnome-shell] this._labelShowing'); } } this._onDestroy(); } _onDestroy() { if(this._resetHoverTimeoutID) { GLib.source_remove(this._resetHoverTimeoutID); this._resetHoverTimeoutID = null; } Main.notify('YUGAN TEJ'); } Are these two same? GLib.source_remove & Glib.Source.remove ?? Thanks
PRATAP PANABAKA posted a review
Please ignore above message. Thank you for your guidance, from line 146, the edited content from extension.js file is GLib.Source.set_name_by_id(this._resetHoverTimeoutId, '[gnome-shell] this._labelShowing'); } } this._onDestroy(); } _onDestroy() { if(this._resetHoverTimeoutID) { GLib.source_remove(this._resetHoverTimeoutID); this._resetHoverTimeoutID = null; } } Are these two same? GLib.source_remove & GLib.Source.remove ?? Thanks
JustPerfection posted a review
Yes, GLib.source_remove and GLib.Source.remove are the same. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions