Review of "Show Desktop Applet" version 3

Details Page Preview

Minimize/unminimize all open windows with a single click. Forked from https://extensions.gnome.org/extension/1194/show-desktop-button/ Features: - Windows-like behavior - Can be placed at the end of panel - Hotkey support (can be activated in settings)

Extension Homepage
https://github.com/Valent-in/Show-Desktop-Applet

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
1. Also do this on disable: settings = null; 2. Use ExtensionUtils.getSettings() instead of creating your own custom function: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Valent-in posted a review
Thanks! Should I reply here? Settings is constant and initialized once (on GS start I suppose). And if I change it to variable and set settings = null, this will cause extension error on next enabling. Not sure about ExtensionUtils.getSettings(). Current solution just works from GS 3.32 or even older.
JustPerfection posted a review
Yes! you can reply here. 1. That's against our review guidelines. You cannot create objects in global scope which is the same as init: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Line 8 and 9 (extension.js) should be moved to enable and null them both on disable. I approved this one since it was like this since version 1 but if you don't fix it for the next version we have to reject. 2. ExtensionUtils.getSettings() is supported on 3.32 and higher.