Review of "Workspace Matrix" version 32

Details Page Preview

Arrange workspaces in a two dimensional grid with workspace thumbnails. If you appreciate this extension please consider to donate $1.

Extension Homepage
https://github.com/mzur/gnome-shell-wsmatrix

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
You should remove the `this._noModsTimeoutId` in destroy (workspacePopup/workspaceSwitcherPopup.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
mzur posted a review
This is done in the parent class: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/dff5bef45cd20e71f61252e09d5a8a29452c6d1a/js/ui/switcherPopup.js#L342
JustPerfection posted a review
Ok but it's better to do it in your _onDestory too since that is a private property. Also removing that in your own _onDestoy doesn't hurt anything. Also, if GNOME Shell removes that, your code is ego compatible.