Review of "Messaging Menu" version 9

Details Page Preview

A Messaging Menu for the Gnome Shell. All Email and Chat Applications in one Place.

Extension Homepage
https://github.com/ChrisLauinger77/gnome-shell-extension-messagingmenu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
47.0 (36) Active
47.0 (35) Inactive
46.2 (34) Inactive
46.1 (33) Inactive
46.0 (32) Inactive
46.0 (31) Inactive
45.0 (30) Inactive
29 Inactive
28 Rejected
27 Active
26 Inactive
25 Inactive
24 Inactive
23 Inactive
22 Inactive
21 Inactive
20 Inactive
19 Inactive
18 Inactive
17 Rejected
16 Inactive
15 Inactive
14 Inactive
13 Inactive
12 Inactive
11 Inactive
10 Inactive
9 Rejected
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Active
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you cannot create objects in init function (line 487 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Rejected because you should remove the timeout in disable (line 374 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources You can do that in `MessageMenu.destroy()`. 3. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Remove these unnecessary imports: - Gdk (line 9 extension.js) - GLib (line 10 extension.js) - Gio (line 13 extension.js) 5. Remove unnecessary file (.prettierrc): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions