Review of "ISS Above" version 4

Details Page Preview

Shows an icon when ISS is above you (+- 1000km)

Extension Homepage
https://gitlab.com/mcepl/gnome-shell-extension-ISS_Above/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection active
1. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 2. Also do this on disable: ```js client = null; ``` 3. Remove unnecessary `print`s from extension.js file: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
Btw, you should use try catch inside that async callback.