Review of "Github Notifications" version 19

Details Page Preview

Integrate Github's notifications within the gnome desktop environment Source code is available here: https://github.com/alexduf/gnome-github-notifications


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
22 Active
21 Active
20 Active
19 Rejected
18 Inactive
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Inactive
5 Active
4 Active
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you cannot create objects in global scope and init function (line 12 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that line to enable and pass that as parameter to `githubNotifications.start()`. 2. Please also do this on disable: ```js githubNotifications = null; ``` 3. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Remove line 131 and replace it with `ExtensionUtils.openPrefs()`. https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/f094b6ddd617112f4d77db062d4bf8cd32df5aa8/js/misc/extensionUtils.js#L219 If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
alexduf posted a review
Thanks for the review! New version on its way with quite a few changes and your recommended fixes.